set language(s) used in the resource #108
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…field in our schema which we currently do not populate in the xml
n-a-t-e
reviewed
Nov 21, 2023
| <lan:PT_Locale> | ||
| {# language: mandatory #} | ||
| <lan:language> | ||
| <lan:LanguageCode codeList="http://standards.iso.org/iso/19115/resources/Codelist/lan/LanguageCode.xml" codeListValue="{{- resource_lang_code -}}"> |
There was a problem hiding this comment.
if resource_lang_code is required, would be good to add to the if statement above. But maybe its not required for validity.
There was a problem hiding this comment.
good point, It's a valid iso record without it. The CIOOS standard requires it however. I will include a check and not generate the xml snippet if false
|
on hold, wait to see if we really need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a mandatory field in our schema which we currently do not populate in the xml